Skip to content

Remember Open Folder chooser location safely - #28

Merged
FernandoAbishai merged 1 commit into
mainfrom
feature/folder-session-hint
Oct 12, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
feature/folder-session-hint

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Member

Summary

  • remember the last successfully selected folder in renderer localStorage only as an Open Folder chooser starting-location hint
  • validate the host payload lexically and use it only as Electron defaultPath / AppKit NSOpenPanel.directoryURL
  • keep folder grants and directory listing strictly after explicit user confirmation; no stat/exists/realpath/list/grant or session-restore authority comes from the persisted hint
  • document the authority boundary and add renderer/Electron/native regression coverage

Verification

  • npm run verify — PASS (31 test files / 146 tests, build, runtime audit, native typecheck/security/window-drag/context-menu smokes)
  • npm run check:clean-room — PASS after the three new files were staged/tracked
  • git diff --check — PASS
  • independent read-only final review on cb4f92e238bab5c7a95798534614a46c038e4257 — PASS, no MUST-FIX

Scope notes

  • no version/release/tag changes
  • no folder grant persistence or automatic folder reopening
  • configurable outer-whitespace preservation remains deferred because the installed MDXEditor trims root boundary whitespace in rich import/export and needs a first-class document-source contract rather than hidden wrapper state

Copilot AI balanced review requested due to automatic review settings October 12, 2026 02:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T02:41:20.070419Z cb4f92e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@FernandoAbishai
FernandoAbishai merged commit ad83d6a into main Oct 12, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the feature/folder-session-hint branch October 12, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants