Skip to content

Split custom themes by appearance - #27

Merged
FernandoAbishai merged 1 commit into
mainfrom
feature/dual-custom-themes
Oct 12, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
feature/dual-custom-themes

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Member

Summary

  • split custom editor CSS into independent Light and Dark slots
  • migrate an existing single custom theme into both slots to preserve current appearance
  • resolve System from macOS appearance and react to live appearance changes
  • choose/remove each slot independently through the existing sanitized CSS picker

Safety boundary

  • renderer preference/schema change only
  • existing Electron/AppKit theme picker and CSS sanitizer are unchanged
  • no paths or filesystem grants are persisted
  • custom editor CSS remains excluded from HTML/PDF/PNG/print/Pandoc export rendering

Validation

  • focused custom-theme/preferences/theme-css: 14/14 PASS
  • npm run verify: 30 suites / 144 tests PASS
  • clean-room, Electron syntax, TypeScript, build and native smokes PASS
  • runtime audit unchanged: 0 critical/high/moderate, 3 low

Independent review requested on exact head 3881d5b; worker runtime was temporarily in PRIME_TRANSFER_IN_PROGRESS, so no verdict is claimed yet.

Copilot AI balanced review requested due to automatic review settings October 12, 2026 02:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T02:27:00.790555Z 3881d5b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@FernandoAbishai

Copy link
Copy Markdown
Member Author

Independent worker review could not be started because Chat On Steroids repeatedly returned PRIME_TRANSFER_IN_PROGRESS during conversation compaction. No independent PASS is claimed.

Final direct review of exact head 3881d5b9a2a4ae7b049c4261a3d4a2705a504025 found no release blocker: legacy single-theme preferences migrate to both slots and old keys are omitted from normalized state; new schema is authoritative; explicit/system resolution and live listener are covered; custom CSS export behavior and existing host picker/sanitizer/authority boundaries are unchanged. Local npm run verify passes 30 suites/144 tests and GitHub source/native are SUCCESS.

@FernandoAbishai
FernandoAbishai merged commit 1063a94 into main Oct 12, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the feature/dual-custom-themes branch October 12, 2026 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants