Skip to content

Add top-level heading page breaks - #26

Merged
FernandoAbishai merged 1 commit into
mainfrom
feature/export-heading-page-breaks
Oct 12, 2026
Merged

FernandoAbishai merged 1 commit into
mainfrom
feature/export-heading-page-breaks

Conversation

@FernandoAbishai

Copy link
Copy Markdown
Member

Summary

  • add an opt-in Page Setup toggle for starting top-level H1 headings after the first on new printed pages
  • keep H2-H6 and nested headings unchanged
  • emit the rule only inside @media print with modern and legacy break properties

Behavior

  • default OFF
  • first H1 never forces a page break
  • PDF and Print honor the rule
  • styled HTML remains visually unchanged onscreen but honors the rule when browser-printed
  • PNG and style-free HTML remain continuous

Safety boundary

  • renderer/Page Setup only; no Electron/native IPC, filesystem, template, CSS-file or authority changes
  • no @page rule or page-geometry override

Validation

  • focused markdown + Page Setup: 12/12 PASS
  • npm run verify: 29 suites / 138 tests PASS
  • clean-room, Electron syntax, TypeScript, build and native smokes PASS
  • runtime audit unchanged: 0 critical/high/moderate, 3 low

Independent read-only review is running on exact head 6afa4a3.

Copilot AI balanced review requested due to automatic review settings October 12, 2026 02:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T02:21:44.153498Z 6afa4a3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@FernandoAbishai
FernandoAbishai merged commit 891f26a into main Oct 12, 2026
2 checks passed
@FernandoAbishai
FernandoAbishai deleted the feature/export-heading-page-breaks branch October 12, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants