feat: add marketplaceExperimentVariant to sponsored listings auction#202
Open
agustinespildora wants to merge 2 commits into
Open
feat: add marketplaceExperimentVariant to sponsored listings auction#202agustinespildora wants to merge 2 commits into
agustinespildora wants to merge 2 commits into
Conversation
Document the optional marketplaceExperimentVariant field (max 10 chars) on the SponsoredListingsAuction request. The engine already accepts, validates and records it in auction reporting (resolved_auction_bids and auction_report); this exposes it in the public docs with a disclaimer so clients can tag and analyze their own experiments. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Products.qualityScores items declared both exclusiveMinimum: 0 and minimum: 0, which redocly's recommended-strict no-mixed-number-range-constraints rule rejects. exclusiveMinimum: 0 already encodes the "greater than 0" constraint and matches the QualityScore component and price field conventions. Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
marketplaceExperimentVariantfield (type: string,maxLength: 10) on the Sponsored Listings auction request (SponsoredListingsAuction) forPOST /v2/auctions. The Auction Engine already accepts, validates (max 10 chars) and records this field in auction reporting (resolved_auction_bidsandauction_report); it was simply undocumented in the public spec.minimum: 0onProducts.qualityScores.items(keepsexclusiveMinimum: 0) so therecommended-strictredocly ruleno-mixed-number-range-constraintspasses.exclusiveMinimum: 0already encodes the "greater than 0" constraint and matches the existingQualityScorecomponent andpricefield conventions.Test Plan
redocly lint --extends recommended-strict topsort-api-v2.yml— valid, 0 errorsprettier --check .— passesyamllint topsort-api-v2.yml— passestypos— passes