feat: decode and display refundable_resource_fee from Soroban tx #290
Open
funds0033-cmyk wants to merge 1 commit into
Open
feat: decode and display refundable_resource_fee from Soroban tx #290funds0033-cmyk wants to merge 1 commit into
funds0033-cmyk wants to merge 1 commit into
Conversation
Extract total_refundable_resource_fee_charged from SorobanTransactionMetaExtV1 as a distinct efundable_resource_fee field, separate from the existing efundable_fee which includes rent_fee_charged. Changes: - crates/core/src/types/report.rs: add efundable_resource_fee: i64 to FeeBreakdown with doc comment explaining the source XDR field - crates/core/src/decode/context.rs: populate the new field from total_refundable_resource_fee_charged; fix pre-existing .as_i64 -> .as_i64() method call bugs in the resourceFee JSON path; update test assertions - crates/cli/src/output/renderers.rs: rename sub-line label to 'Refundable Resource Fee', update test fixture and assertion - apps/web/src/lib/types.ts: add FeeBreakdown, ResourceSummary, and full TransactionContext interfaces; add refundable_resource_fee with JSDoc - apps/web/src/components/decode/ContextSummary.tsx: implement fee breakdown panel displaying refundable_resource_fee as a labeled indented row with explanatory note; add resource usage bars; follows CLI render_fee_breakdown pattern exactly Closes Toolbox-Lab#277
|
@funds0033-cmyk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@funds0033-cmyk please fix merge conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract total_refundable_resource_fee_charged from SorobanTransactionMetaExtV1 as a distinct
efundable_resource_fee field, separate from the existing
efundable_fee which includes rent_fee_charged.
Changes:
efundable_resource_fee: i64 to FeeBreakdown with doc comment explaining the source XDR field
Closes #277