Skip to content

test: align bootstrap check with shared backup discovery - #115

Merged
Timpan4 merged 1 commit into
mainfrom
fix/bootstrap-discovery-test
Sep 15, 2026
Merged

Timpan4 merged 1 commit into
mainfrom
fix/bootstrap-discovery-test

Conversation

@Timpan4

@Timpan4 Timpan4 commented Sep 15, 2026 •

Copy link
Copy Markdown
Owner

The Pester workflow failed because the bootstrap fallback check still expected backup-manifest.json in bootstrap.ps1 after discovery moved to the shared module. Update the assertion to check the Find-BackupManifest call.

Validation: reproduced the original failure, then passed all 288 tests with Invoke-Pester -Path tests -CI. git diff --check passed.

Summary by CodeRabbit

  • Tests
    • Updated bootstrap fallback coverage to verify backup manifest discovery when repository cloning fails.

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: ce73a2d4-96db-49e2-a0ef-e77162ec22a5

📥 Commits

Reviewing files that changed from the base of the PR and between adca3bb and e1aa3b4.

📒 Files selected for processing (1)
  • tests/Bootstrap.Tests.ps1

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The test assertion for the repository clone failure fallback now checks for Find-BackupManifest in bootstrap.ps1 instead of the backup-manifest.json string.

Changes

Backup Manifest Validation

Layer / File(s) Summary
Update backup-manifest assertion
tests/Bootstrap.Tests.ps1
The test now expects bootstrap.ps1 to reference Find-BackupManifest.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e1aa3

The bootstrap fallback test now checks the current helper reference, with no concrete merge-blocking risk identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the test update to use shared backup discovery through Find-BackupManifest.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/bootstrap-discovery-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Timpan4
Timpan4 merged commit ac7c74b into main Sep 15, 2026
3 checks passed
@Timpan4
Timpan4 deleted the fix/bootstrap-discovery-test branch September 15, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant