Skip to content

fix: preserve ISO builder decoding in Windows PowerShell - #109

Merged
Timpan4 merged 1 commit into
mainfrom
test/iso-build-integration
Sep 7, 2026
Merged

Timpan4 merged 1 commit into
mainfrom
test/iso-build-integration

Conversation

@Timpan4

@Timpan4 Timpan4 commented Sep 7, 2026

Copy link
Copy Markdown
Owner

A real ISO build under Windows PowerShell 5.1 failed before validation because build-iso.ps1 contains UTF-8 characters without a BOM. Native decoding changed the parsed structure and executed catch as a command. Add the UTF-8 BOM and a regression that invokes the Windows PowerShell parser and verifies the main try/catch/finally block.

Validation:

  • Focused Windows PowerShell 5.1 parser regression passed.
  • Independent requested review found no actionable defects; git diff --check passed.
  • Installed Microsoft-signed ADK Deployment Tools 10.1.26100.2454 and all six applicable KB5101684 patches on a host with no previous Deployment Tools installation; all installers returned 0.
  • Elevated Windows PowerShell 5.1 build using Windows 11 25H2 x64 media passed Windows SIM schema validation, indexed metadata validation of all 11 editions, staging validation, and oscdimg generation with exit 0.
  • Generated ISO is 8,454,518,784 bytes. Remounted the generated ISO and verified its required setup payload and unattend references. Used apps-template.json as the disposable apps.json; no personal configuration was copied.

This completes the real build and freshly installed prerequisite validation left open by #107. No Windows installation or boot test was performed or required by these issues.

Closes #58
Closes #59

@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 52 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 342a470d-fa95-4360-9d99-ce449bc46935

📥 Commits

Reviewing files that changed from the base of the PR and between 7c9b29b and e6937c4.

📒 Files selected for processing (2)
  • build-iso.ps1
  • tests/BuildIso.Tests.ps1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Timpan4
Timpan4 merged commit 7f1825d into main Sep 7, 2026
3 checks passed
@Timpan4
Timpan4 deleted the test/iso-build-integration branch September 7, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align ISO prerequisites with mandatory unattend validation Validate source Windows version and architecture before ISO staging

1 participant