Skip to content

Contributing.md mentions root npm run build / test:e2e, but neither exists #240

Closed

Description

@crazy-explore-r

While setting up the repo I noticed the Testing section in wiki/Contributing.md tells contributors to run:

npm run build
npm run test:e2e

and says npm run build is "the repository static asset validator" and npm run test:e2e runs Playwright.

Problem is, none of that exists at the repo root — there's no root package.json, no Playwright config anywhere, and no test:e2e script. If you git clone and try it fresh, npm run build just fails with no package.json found. The only real npm run build lives inside desktop-app/, and it builds the Neutralino standalone binaries, not a static asset validator. Checked .github/workflows/desktop-build.yml too and that's the only place npm actually runs in CI, scoped to desktop-app/.

So either these root scripts were planned but never added, or the docs are just out of date. Either way it's a rough first impression for anyone following Contributing.md step by step.

Happy to send a docs PR to fix the Testing section to match what's really there, if that's the preferred direction over adding the missing scripts.

Activity

  1. ThisIs-Developer commented on Aug 11, 2026

    @ThisIs-Developer
    Owner

    @crazy-explore-r Hello, thank you for noticing and reporting this.

    I’m actually using these tests locally, but as you pointed out, they are not currently available in the remote repository. I would like to add them there as well so contributors can use the same testing workflow.

    I’ll create a PR and add the required test setup very soon.

    Thank you again for catching this and bringing it to my attention!

  2. added
    documentationREADME, Wiki, guides, comments, or documentation updates.
    enhancementNew feature, improvement, or usability enhancement.
    on Aug 11, 2026
  3. ThisIs-Developer commented on Aug 11, 2026

    @ThisIs-Developer
    Owner

    Hi @crazy-explore-r,

    I’ve now published the shared test-suite setup in #241. It includes the root package.json scripts, locked dependencies, Playwright configuration, fixtures, helpers, and updated contributor documentation. Please take a look when you have a chance.

    I initially planned to add a Playwright GitHub Actions workflow as well, but I removed it because this project’s testing is primarily performed locally before changes are pushed or submitted for review. The Playwright suite will therefore remain contributor-run and local-only. I also removed the test:ci script and the CI-specific Playwright configuration.

    Thank you again for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationREADME, Wiki, guides, comments, or documentation updates.enhancementNew feature, improvement, or usability enhancement.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions