Skip to content

Use admin UI to v1.44.1 (PP-4867) - #3635

Merged
tdilauro merged 1 commit into
mainfrom
chore/admin-ui-v1.44.1
Aug 8, 2026
Merged

Use admin UI to v1.44.1 (PP-4867)#3635
tdilauro merged 1 commit into
mainfrom
chore/admin-ui-v1.44.1

Conversation

@tdilauro

@tdilauro tdilauro commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Description

Use Admin UI v1.44.1.

Motivation and Context

New Palace Manager release.

[Jira PP-4867]

How Has This Been Tested?

CI tests pass.

Checklist

  • N/A - I have updated the documentation accordingly.
  • All new and existing tests passed.

@claude

claude Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Claude finished @tdilauro's task in 23s —— View job


Code Review

  • Gather context (PR diff, config.py, version references)
  • Analyze the change
  • Post review

Summary

Clean, single-line bump of the bundled admin UI package version from 1.44.0 to 1.44.1, matching the linked circulation-admin v1.44.1 release. PACKAGE_VERSION is the only hardcoded occurrence in the repo (src/palace/manager/api/admin/config.py:89); every test that touches it (tests/manager/api/admin/test_config.py, tests/manager/core/test_app_server.py) references the constant symbolically rather than a literal, so nothing else needs updating. The TPP_CIRCULATION_ADMIN_PACKAGE_VERSION override path is untouched, so no README change is required per CLAUDE.md's environment-variable rule. No findings.
| Branch: chore/admin-ui-v1.44.1

@greptile-apps

greptile-apps Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the Palace Manager backend to serve Admin UI v1.44.1.

  • Changes the default @thepalaceproject/circulation-admin package version from 1.44.0 to 1.44.1.
  • Leaves package resolution, CDN loading, environment overrides, and static asset names unchanged.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable defects identified in the Admin UI version update.

The change only advances the configured Admin UI package to the release identified by the PR, while preserving the existing package-resolution and asset-loading behavior.

Important Files Changed

Filename Overview
src/palace/manager/api/admin/config.py Updates the default Admin UI package version to 1.44.1 with no identified correctness or compatibility defect.

Reviews (1): Last reviewed commit: "Use admin UI to v1.44.1 (PP-4867)" | Re-trigger Greptile

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.54%. Comparing base (9c321e3) to head (5958cef).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3635   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         509      509           
  Lines       46854    46854           
  Branches     6406     6406           
=======================================
+ Hits        43829    43830    +1     
+ Misses       1955     1954    -1     
  Partials     1070     1070           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tdilauro
tdilauro merged commit 1c7746f into main Aug 8, 2026
25 checks passed
@tdilauro
tdilauro deleted the chore/admin-ui-v1.44.1 branch August 8, 2026 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant