rework Makefile to run golangci lint in check#15
Merged
raghavendra-talur merged 3 commits intoJun 23, 2026
Merged
Conversation
So far, `make lint` and `make check` only ran the lint.go.light target which dot run golangci-lint. This change reworks some make targets such that * A new lint.go target is added as analias to lint.go.full *lint runs the full go linting (lint.go). * check runs the full lint. As a consequence, `make check` now runs the full linting including golangci-lint. In particular, as the CI runs `make check`, the CI now tests for golangci-lint regressions. Signed-off-by: Michael Adam <obnox@samba.org>
The lint.light target was not used anywhere and served no real purpose. This change removes this unused target. Signed-off-by: Michael Adam <obnox@samba.org>
There was a problem hiding this comment.
Pull request overview
This PR adjusts the Makefile’s lint/check wiring so that make check (and thus CI) runs the full Go lint suite, including golangci-lint, instead of only the “light” vet+gofmt checks.
Changes:
- Switch
checkto depend onlint(full lint) rather than the removedlint.light. - Introduce
lint.goas an alias target forlint.go.fulland routelintthrough it. - Remove the unused
lint.lighttarget.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change updates developer and CLAUD docs to reflect the changes in check and lint targets. Signed-off-by: Michael Adam <obnox@samba.org>
raghavendra-talur
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far,
make lintandmake checkonly ran thelint.go.lighttarget instead oflint.go.full, so it did not run golangci-lint.This change reworks some make targets such that:
lint.gotarget is added as an alias tolint.go.fullcheckruns the fulllint.lint.lighttarget is removed.As a consequence,
make checknow runs the full linting, including golangci-lint.In particular, as the CI runs
make check, the CI now tests for golangci-lint regressions.