Makefile/CI: Add linting of github workflow files#13
Merged
raghavendra-talur merged 2 commits intoJun 18, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Adds GitHub Actions workflow linting to the project’s existing make-based lint/check pipeline so CI (which runs make check) validates workflow files via actionlint.
Changes:
- Introduces
ACTIONLINTand a newlint.workflowstarget to lint.github/workflowsfiles. - Adds a
lint.lightaggregation target and updatescheckto use it (socheckincludes workflow linting). - Updates
lintto include workflow linting and run the “full” Go lint suite.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This change adds linting of the github workflow file(s) using the actionlint tool. For developer convenience, this can be invoked as `make lint.workflows`. Additionally, ome make target dependencies are slightly rearrangrd so that, for example lint and check run workflow linting. Signed-off-by: Michael Adam <obnox@samba.org>
This change adds some informational messages to Makefile linting with `make lint.make` Signed-off-by: Michael Adam <obnox@samba.org>
obnoxxx
force-pushed
the
make-lint-workflows
branch
from
7b9cca7 to
3f5fa14
Compare
obnoxxx
changed the title
raghavendra-talur
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds lointing of github workflow files with the actionlint command via
make lint.workflows.Some of the makefile target dependencies are also rearranged so that
make lintandmake checkalso lint workflows.In particular, the CI will lint the workflow files on PRs with this.