Conversation
TheCodeHeist-Coder
self-requested a review
September 27, 2026 07:04
Owner
|
Awesome work! 🔥 Welcome aboard, and looking forward to more contributions from you. |
TheCodeHeist-Coder
approved these changes
Sep 27, 2026
TheCodeHeist-Coder
left a comment
Owner
There was a problem hiding this comment.
It's a clean and as expected code
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #159.
The quiz join form now normalizes participant input before it is submitted:
Why
Previously the browser's
maxLength={6}could count pasted whitespace toward the PIN length before the value was normalized. A valid copied code could therefore be truncated and produce a misleading "Quiz not found" error.Nicknames were also submitted without trimming, and a whitespace-only nickname passed the existing truthiness check.
Verification
git diff --checkpassesExisting lint baseline
The repository-wide frontend lint already fails on unrelated files in current
main.Before this change:
After this change:
The reduction comes from removing the existing
anyinJoinQuiz.tsx. Both files changed by this PR are lint-clean.