feat(blocks): add Brand Kit logo variation - #104
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classification
Logo uses
core/imagepluscampaignbridge/brand-data. CampaignBridge does not register a duplicate Logo block or a second asset store. Theme import copies the current Site Logo into Brand Kit version 3, and compilation never reads live theme or Media Library data.Validation
pnpm buildpnpm qa:fastpnpm test— 1,132 tests, 5,305 assertionspnpm exec playwright test tests/e2e/brand-logo.spec.tspnpm release:package && pnpm release:verifyRefs #96