D5-S15 — Mcp: the transport, the connection principal and invocation - #221
Merged
Merged
Conversation
Adopts the official MCP C# SDK for transport, session and filter pipeline, projected at the boundary per the SDK-adoption decision. Adds the fixed invocation order (catalogue lookup, tenant resolution, argument parse, authorize, entitlement, invoke in its own operation scope, audit), McpError (UnknownTool, InvalidArguments, ConnectionUnauthenticated), connection-level principal binding, and per-invocation audit with no argument payload. Grants Mcp InternalsVisibleTo from Core for the authentication chain reuse. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelContextProtocol.Core/ModelContextProtocol.AspNetCorefor the MCP transport, session and filter pipeline, projected at the boundary perdesign/90-decisions.md(2026-08-29) — no SDK type appears in Platform's public surface.McpError(UnknownTool,InvalidArguments,ConnectionUnauthenticated) and installs Platform's own list/call filters ahead of the SDK's default authorization filter, so unregistered and registered-but-unexposed tools answer identically and never disclose existence.Required, and no argument payload.SubZeroDev.Platform.Mcpaccess to Core'sAuthenticationChainviaInternalsVisibleToonSubZeroDev.Platform.Core.csproj, mirroring Hosting's existing access, to reuse the same authentication seam the HTTP path uses.Test plan
dotnet build— succeeds, 0 warnings, 0 errors.dotnet testsuite — last full run did not finish inside this session; needs a clean confirming run before merge (McpInvocationTests,McpTests,PackageGraphTestsat minimum).Closes #183.
🤖 Generated with Claude Code