Skip to content

dbSta: check LEF pins against Liberty#10821

Open
naveenvenk17 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-ip-checker-liberty-pins-4872
Open

dbSta: check LEF pins against Liberty#10821
naveenvenk17 wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
naveenvenk17:nv-ip-checker-liberty-pins-4872

Conversation

@naveenvenk17

Copy link
Copy Markdown
Contributor

Summary

  • add LEF/LIB-CHK-012 to warn when a LEF non-supply pin is missing from the matching Liberty cell
  • keep the check conditional on a matching Liberty cell so LEF-only IP checks do not become noisy
  • register a focused pass/fail regression fixture in both Bazel and CMake

Related to #4872.

Tests

  • PASS: git diff --check
  • PASS: bazelisk build --jobs=4 --local_cpu_resources=4 //src/dbSta:IpChecker
  • BLOCKED: bazelisk test --jobs=4 --local_cpu_resources=4 //src/dbSta/test:check_ip_liberty_pins-tcl_test on the Ubuntu 22.04 GCP VM fails before test execution while linking openroad with unresolved __isoc23_* glibc symbols from the Bazel LLVM/sysroot toolchain.

@naveenvenk17 naveenvenk17 requested a review from a team as a code owner July 5, 2026 15:38
@naveenvenk17 naveenvenk17 requested a review from jhkim-pii July 5, 2026 15:38
@github-actions github-actions Bot added the size/M label Jul 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new check, LEF/LIB-CHK-012, to verify that LEF signal pins exist in the corresponding Liberty cell. It implements the checkLibertyPinPresence method in IpChecker and adds a new pass/fail regression test check_ip_liberty_pins to validate this functionality. There are no review comments, so I have no feedback to provide.

Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
@naveenvenk17 naveenvenk17 force-pushed the nv-ip-checker-liberty-pins-4872 branch from 0da497b to d34074a Compare July 5, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant