dbSta: check LEF pins against Liberty#10821
Open
naveenvenk17 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new check, LEF/LIB-CHK-012, to verify that LEF signal pins exist in the corresponding Liberty cell. It implements the checkLibertyPinPresence method in IpChecker and adds a new pass/fail regression test check_ip_liberty_pins to validate this functionality. There are no review comments, so I have no feedback to provide.
Signed-off-by: Naveen Venkat <archgen.guest@nyayanidhi.in>
0da497b to
d34074a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEF/LIB-CHK-012to warn when a LEF non-supply pin is missing from the matching Liberty cellRelated to #4872.
Tests
git diff --checkbazelisk build --jobs=4 --local_cpu_resources=4 //src/dbSta:IpCheckerbazelisk test --jobs=4 --local_cpu_resources=4 //src/dbSta/test:check_ip_liberty_pins-tcl_teston the Ubuntu 22.04 GCP VM fails before test execution while linkingopenroadwith unresolved__isoc23_*glibc symbols from the Bazel LLVM/sysroot toolchain.