Repository navigation
Ensure Switch controller paradigm exists and recover Mac controllers after sleep - #87
Open
actuallyitsnathaniel wants to merge 2 commits into
Conversation
controller paradigm exists and recover Mac controllers after sleep
Contributor
Author
|
reviewing failed checks rn |
actuallyitsnathaniel
requested review from
ThatGuyMcd and
swhitt
as code owners
November 2, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switch Pro / Joy-Con defaults now follow the controller face etiquette: printed A/B/X/Y match the binding tokens. SDL2 pins
SDL_GAMECONTROLLER_USE_BUTTON_LABELS=1; SDL3's position-mode reports are remapped in the SDL3 input host before bindings see them. NSO N64 / GameCube pads stay on their existing label-oriented paths.Also fixes dead input after closing a MacBook lid while paused: on wake we treat a frontmost app as input-capable when SDL's focus bit is stale, and force-reopen controller handles so pads come back in the same session without unplugging.
Pattern checklist
runtime-recomp/,modding/orscripts/(no newpatches/<name>/)*.patchfiles registered inpatches/manifest.json(n/a)guest-hooks/hooks.toml; symbols only viasymbols/*.toml(n/a)docs/CONTROLLERS.mdnote only)netplay/legacy_identity.hppupdated (reviewed by both owners) if simulation, wire or owned-service behaviour changed(n/a)
python scripts/check.py --suite guardpasses locally (DKRControllerFaceEtiquetteadded)/ iOS / Android not rebuilt for this PR.
Risk
Low. Etiquette remap is limited to Switch Pro / Joy-Con families; Xbox/PS and NSO N64/GC are unchanged. Mac wake recovery only force-reopens pads and relaxes the focus gate while
NSAppis active, so backgrounded windows still drop gameplay input. Capsulebase_sha256pins updated for the touched first-party files. Revert the commit to roll back.