renames, renames everywhere

So we're shifting the balance a bit here.
ConventionResult is really becoming a conventionContext which will act as a context object gluing together all various pieces of the pipeline, isolating all the statics etc. Kind of like HttpContext or OperationContext in WCF

we're changing the interface to IConventionResultContext. While it's not the best name it's the best I could come up with, without calling it factory (which it's not, since it doesn't return anything) or calling it provider which is just wrong

Author: kkozmic

TestStack.ConventionTests.Tests/ConventionAssertionClassTests.cs

@@ -33,7 +33,7 @@ public ConventionReportFailure Format(string failingData)
 
         public class FailingConvention : IConvention<FakeData>
         {
-            public void Execute(FakeData data, IConventionResult result)
+            public void Execute(FakeData data, IConventionResultContext result)
             {
                 result.Is("Header", new[] {"Different"});
             }

TestStack.ConventionTests.Tests/TestConventions/CollectionsRelationsConvention.cs

@@ -10,7 +10,7 @@ public class CollectionsRelationsConvention : IConvention<Types>
     {
         public string ConventionTitle { get; private set; }
 
-        public void Execute(Types data, IConventionResult result)
+        public void Execute(Types data, IConventionResultContext result)
         {
             ConventionTitle = "well, does the header apply here all across the board? How would that work for CSV?";
             var types = data.TypesToVerify;

TestStack.ConventionTests/Conventions/AllClassesHaveDefaultConstructor.cs

@@ -6,7 +6,7 @@
 
     public class AllClassesHaveDefaultConstructor : IConvention<Types>
     {
-        public void Execute(Types data, IConventionResult result)
+        public void Execute(Types data, IConventionResultContext result)
         {
             result.Is("Types must have a default constructor",
                 data.TypesToVerify.Where(t => t.HasDefaultConstructor() == false));

TestStack.ConventionTests/Conventions/AllMethodsAreVirtual.cs

@@ -6,7 +6,7 @@
 
     public class AllMethodsAreVirtual : IConvention<Types>
     {
-        public void Execute(Types data, IConventionResult result)
+        public void Execute(Types data, IConventionResultContext result)
         {
             result.Is("Methods must be virtual", data.TypesToVerify.SelectMany(t => t.NonVirtualMethods()));
         }

TestStack.ConventionTests/Conventions/ClassTypeHasSpecificNamespace.cs

@@ -31,7 +31,7 @@ public ClassTypeHasSpecificNamespace(Func<Type, bool> classIsApplicable, string
             this.classType = classType;
         }
 
-        public void Execute(Types data, IConventionResult result)
+        public void Execute(Types data, IConventionResultContext result)
         {
             result.IsSymmetric(
                 string.Format("{0}s must be under the '{1}' namespace", classType, namespaceToCheck),

TestStack.ConventionTests/Conventions/FilesAreEmbeddedResources.cs

@@ -12,7 +12,7 @@ public FilesAreEmbeddedResources(string fileExtension)
 
         public string FileExtension { get; private set; }
 
-        public void Execute(ProjectFiles data, IConventionResult result)
+        public void Execute(ProjectFiles data, IConventionResultContext result)
         {
             result.Is(
                 string.Format("{0} Files must be embedded resources", FileExtension),

TestStack.ConventionTests/Conventions/ProjectDoesNotReferenceDllsFromBinOrObjDirectories.cs

@@ -8,7 +8,7 @@ public class ProjectDoesNotReferenceDllsFromBinOrObjDirectories : IConvention<Pr
     {
         const string AssemblyReferencingObjRegex = @"^(?<assembly>.*?(obj|bin).*?)$";
 
-        public void Execute(ProjectReferences data, IConventionResult result)
+        public void Execute(ProjectReferences data, IConventionResultContext result)
         {
             result.Is("Project must not reference dlls from bin or obj directories",
                 data.References.Where(IsBinOrObjReference));

TestStack.ConventionTests/IConvention.cs

@@ -2,6 +2,6 @@
 {
     public interface IConvention<in T> where T : IConventionData
     {
-        void Execute(T data, IConventionResult result);
+        void Execute(T data, IConventionResultContext result);
     }
 }

…ack.ConventionTests/IConventionResult.cs …ventionTests/IConventionResultContext.csTestStack.ConventionTests/IConventionResult.cs renamed to TestStack.ConventionTests/IConventionResultContext.cs TestStack.ConventionTests/IConventionResult.cs renamed to TestStack.ConventionTests/IConventionResultContext.cs

@@ -3,7 +3,7 @@
     using System;
     using System.Collections.Generic;
 
-    public interface IConventionResult
+    public interface IConventionResultContext
     {
         void Is<T>(string resultTitle, IEnumerable<T> failingData);
 

…entionTests/Internal/ConventionResult.cs …ntionTests/Internal/ConventionContext.csTestStack.ConventionTests/Internal/ConventionResult.cs renamed to TestStack.ConventionTests/Internal/ConventionContext.cs TestStack.ConventionTests/Internal/ConventionResult.cs renamed to TestStack.ConventionTests/Internal/ConventionContext.cs

@@ -5,13 +5,13 @@
     using System.Linq;
     using TestStack.ConventionTests.Reporting;
 
-    public class ConventionResult : IConventionResult
+    public class ConventionContext : IConventionResultContext
     {
         readonly List<ResultInfo> conventionResults;
         readonly string dataDescription;
         readonly IList<IReportDataFormatter> formatters;
 
-        public ConventionResult(string dataDescription, IList<IReportDataFormatter> formatters)
+        public ConventionContext(string dataDescription, IList<IReportDataFormatter> formatters)
         {
             this.formatters = formatters;
             this.dataDescription = dataDescription;