starting to refactor formatters.

step one - removing static dependency

Author: kkozmic

TestStack.ConventionTests/Internal/ConventionResult.cs

@@ -9,9 +9,11 @@ public class ConventionResult : IConventionResult
     {
         readonly List<ResultInfo> conventionResults;
         readonly string dataDescription;
+        readonly IList<IReportDataFormatter> formatters;
 
-        public ConventionResult(string dataDescription)
+        public ConventionResult(string dataDescription, IList<IReportDataFormatter> formatters)
         {
+            this.formatters = formatters;
             this.dataDescription = dataDescription;
             conventionResults = new List<ResultInfo>();
         }
@@ -62,10 +64,9 @@ public void IsSymmetric<TResult>(
                 secondSetFailureTitle, secondSetFailingData);
         }
 
-        static ConventionReportFailure FormatData<T>(T failingData)
+        ConventionReportFailure FormatData<T>(T failingData)
         {
-            var formatter = Convention.Formatters.FirstOrDefault(f => f.CanFormat(failingData));
-
+            var formatter = formatters.FirstOrDefault(f => f.CanFormat(failingData));
             if (formatter == null)
             {
                 throw new NoDataFormatterFoundException(

TestStack.ConventionTests/Internal/Executor.cs

@@ -11,7 +11,7 @@ public static ResultInfo[] GetConventionResults<TDataSource>(IConvention<TDataSo
             if (!data.HasData)
                 throw new ConventionSourceInvalidException(string.Format("{0} has no data", data.Description));
 
-            var resultGatherer = new ConventionResult(data.Description);
+            var resultGatherer = new ConventionResult(data.Description, Convention.Formatters);
             convention.Execute(data, resultGatherer);
 
             return resultGatherer.ConventionResults;
@@ -26,7 +26,7 @@ public static ResultInfo[] GetConventionResultsWithApprovedExeptions<TDataSource
             if (!data.HasData)
                 throw new ConventionSourceInvalidException(string.Format("{0} has no data", data.Description));
 
-            var resultGatherer = new ConventionResult(data.Description);
+            var resultGatherer = new ConventionResult(data.Description, Convention.Formatters);
             convention.Execute(data, resultGatherer);
             foreach (var conventionResult in resultGatherer.ConventionResults)
             {