Add PR-time CI for build, lint, and typecheck#48
Merged
Merged
Conversation
Build/typecheck previously only ran during the publish pipeline on pushes to main, so a broken PR could merge silently and only surface as a failed release later. This adds a pull_request (and push to main) workflow that installs, lints, builds, and typechecks every package, mirroring the publish workflow's pnpm/Node setup steps to keep the two consistent. iobroker.teslemetry's typecheck script is named `check` rather than `tsc`, so it needs its own step alongside the `pnpm -r --no-bail tsc` run that covers the other four packages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
main, so a broken PR merges silently and only fails later at release time (found in the fleet CI audit)..github/workflows/ci.ymltriggered onpull_request(andpushtomain) that runs install, lint, build, and typecheck across the monorepo..github/workflows/publish.ymlso the two workflows stay in sync.publish.ymlitself is untouched.api,homebridge-teslemetry,n8n-nodes-teslemetry,node-red-contrib-teslemetryviapnpm -r --no-bail tsc, plus a dedicated step foriobroker.teslemetry, whose typecheck script is namedcheckrather thantscand is silently skipped by the recursivetscinvocation.pnpm lint(oxlint .) script - no new lint config added.What Changed
.github/workflows/ci.yml.Testing
pnpm install --frozen-lockfile,pnpm lint,pnpm -r run build,pnpm -r --no-bail tsc,pnpm --filter iobroker.teslemetry check- all green.Full narrative / original brief
[E10.1 follow-up, from the fleet CI audit] typescript-teslemetry: add PR-time CI.
The audit found build/typecheck only run during publish on main pushes - there is NO validation on pull requests, so a broken PR merges silently and only fails later in the publish pipeline.
Scope:
.github/workflows/ci.ymlonpull_request(and push to main): pnpm install, build, and typecheck across the monorepo, covering all four packages that had TS7 failures: api, homebridge-teslemetry, n8n-nodes-teslemetry, iobroker.teslemetry (whose typecheck script ischeck, nottsc).