Repository navigation
fix(i18n): fix syntax error in es_es.json missing comma - #1109
Merged
gniftygnome merged 1 commit intoOct 17, 2026
Merged
Conversation
Resolves TerraformersMC#1101 by adding the missing comma after option.modmenu.button_update_badge.false on the 1.21.9 branch so the Spanish localization file parses as valid JSON.
Contributor
|
There is no 1.21.9 "maintenance" branch. Maintained versions of 1.21 are 1.21.1 and 1.21.11. |
Author
|
Thanks for the clarification @gniftygnome! Since #1101 specifically mentioned the 1.21.9 branch, I submitted the syntax fix directly against it. Since 1.21.1 and 1.21.11 are the maintained release lines and are already valid, feel free to close this PR if 1.21.9 won't be receiving maintenance releases. |
Contributor
|
I'll merge it; I just can't say when it will get published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1101 (part 1) on the 1.21.9 maintenance branch.
In src/main/resources/assets/modmenu/lang/es_es.json, line 172 was missing a comma after "option.modmenu.button_update_badge.false": "NO". This caused JSON parsing to fail (Expecting ',' delimiter: line 173 column 3), which prevented the Spanish localization file from loading properly.
Changes