Skip to content

Make badges data driven - #1104

Open
1foxy2 wants to merge 2 commits into
TerraformersMC:26.4from
1foxy2:26.4
Open

1foxy2 wants to merge 2 commits into
TerraformersMC:26.4from
1foxy2:26.4

Conversation

@1foxy2

@1foxy2 1foxy2 commented Oct 11, 2026 •

Copy link
Copy Markdown

Allows mods and resourcepacks to add or replace badges using resource packs.

an example file at assets//modmenu/badge/example.json

{
	"text": {
		"translate": "examplepack.badge.example" // text component
	},
	"outline_color": "#FF2b4b7c",
	"fill_color": "#FF0e2a55",
       "text_color": "#FFFFFFFF" // optional text color, defaults to FFCACACA
	"search_terms": "examplepack.searchTerms.example" // optional search terms
	"library": true // optional field if mods with this badge should be hidden like library, defaults to false
}

@gniftygnome

gniftygnome commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

See #191; I generally agree with that decision.

(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

@1foxy2

1foxy2 commented Oct 13, 2026

Copy link
Copy Markdown
Author

See #191; I generally agree with that decision.

(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

it is already possible to easily extend the enum with mixins, so the only difference would be what normal users cant change badges without code or addon.

@Jab125

Jab125 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

See #191; I generally agree with that decision.
(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

it is already possible to easily extend the enum with mixins, so the only difference would be what normal users cant change badges without code or addon.

It’s hard on purpose to discourage it

@1foxy2

1foxy2 commented Oct 14, 2026 •

Copy link
Copy Markdown
Author

See #191; I generally agree with that decision.
(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

it is already possible to easily extend the enum with mixins, so the only difference would be what normal users cant change badges without code or addon.

It’s hard on purpose to discourage it

if you're talking about mixins, then its pretty easy for modders. and if you're talking about normal users who just want to change badges for themselfes then why should you discourage it?

@Jab125

Jab125 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

See #191; I generally agree with that decision.
(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

it is already possible to easily extend the enum with mixins, so the only difference would be what normal users cant change badges without code or addon.

It’s hard on purpose to discourage it

if you're talking about mixins, then its pretty easy for modders. and if you're talking about normal users who just want to change badges for themselfes then why should you discourage it?

The more 'cursed' things you need to do to add badges, the more discouraging it is, enum extension is one of those things. It's discouraged because an official API means that every person's first mod's gonna have their own badges (speaking from experience).
If a normal user still wants more badges, then they can use that Mod Menu badge lib

@1foxy2

1foxy2 commented Oct 14, 2026

Copy link
Copy Markdown
Author

See #191; I generally agree with that decision.
(Also, https://modrinth.com/mod/modmenu-badges-lib exists for those who want a candy explosion of badges...)

it is already possible to easily extend the enum with mixins, so the only difference would be what normal users cant change badges without code or addon.

It’s hard on purpose to discourage it

if you're talking about mixins, then its pretty easy for modders. and if you're talking about normal users who just want to change badges for themselfes then why should you discourage it?

The more 'cursed' things you need to do to add badges, the more discouraging it is, enum extension is one of those things. It's discouraged because an official API means that every person's first mod's gonna have their own badges (speaking from experience). If a normal user still wants more badges, then they can use that Mod Menu badge lib

i wouldn't call enum extension cursed and you can always add an option to only get badges from resourcepacks which would be enabled by default. Mod menu badge lib is per mod, so good luck having to change all library badge in a 500 mods modpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants