fix: correct typos in CLI usage output and an exception message - #430
Open
Avicennasis wants to merge 1 commit into
Open
fix: correct typos in CLI usage output and an exception message#430Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
- CSFix.cs: 'assmbly' -> 'assembly' (10 occurrences) in the argument placeholder names printed by usage(). Text output only. - LiveDotNet.cs: FormatException message 'Invalid ip-adress' -> 'Invalid ip-address'. No identifiers were renamed and no logic was changed.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two verified spelling typos in strings that are printed to the user. Both were checked against the live
masterbranch before editing.Source/VSProj/Src/Tools/CSFix.csassmbly->assembly, 10 occurrences, all inside the threeConsole.WriteLine(...)literals inusage():These are the placeholder names shown in the CLI help text. They are positional arguments, so nothing parses them by name and the change is text-only.
grep -rn assmblyconfirms the misspelling appears nowhere else in the repository - no docs, build scripts or.batfiles referenceassmbly_path.Source/Misc/LiveDotNet/Editor/LiveDotNet.csthrow new FormatException("Invalid ip-adress");->"Invalid ip-address"This string is not referenced by any test, doc or FAQ entry in the repository.
Notes for reviewers
ilfixAassembly,assmeblyPath,tranlaterand the parameterperfix(plus its matching<param name="perfix">doc tag). Those are all real identifiers, so I deliberately left them alone - renaming them is a separate, API-visible decision for the maintainers. (CSFix.cs:100already carries a//TODO: tranlater的名字不太合适note.)Console.WriteLine("Error: the new assembly must not be inject, ...")unchanged even thoughinjectshould grammatically beinjected: that exact string is quoted verbatim as a heading inDoc/faq.md, and it is the sort of message users paste into a search engine. Changing it would desync the FAQ and break those searches. Happy to add it (and the matching FAQ line) if you would prefer.