Skip to content

fix: correct typos in CLI usage output and an exception message - #430

Open
Avicennasis wants to merge 1 commit into
Tencent:masterfrom
Avicennasis:docs/fix-typos
Open

fix: correct typos in CLI usage output and an exception message#430
Avicennasis wants to merge 1 commit into
Tencent:masterfrom
Avicennasis:docs/fix-typos

Conversation

@Avicennasis

Copy link
Copy Markdown

Summary

Fixes two verified spelling typos in strings that are printed to the user. Both were checked against the live master branch before editing.

Source/VSProj/Src/Tools/CSFix.cs

assmbly -> assembly, 10 occurrences, all inside the three Console.WriteLine(...) literals in usage():

IFix -inject core_assmbly_path assmbly_path config_path patch_file_output_path injected_assmbly_output_path ...
IFix -inherit_inject core_assmbly_path assmbly_path config_path patch_file_output_path injected_assmbly_output_path inherit_assmbly_path ...
IFix -patch core_assmbly_path assmbly_path injected_assmbly_path config_path patch_file_output_path ...

These are the placeholder names shown in the CLI help text. They are positional arguments, so nothing parses them by name and the change is text-only. grep -rn assmbly confirms the misspelling appears nowhere else in the repository - no docs, build scripts or .bat files reference assmbly_path.

Source/Misc/LiveDotNet/Editor/LiveDotNet.cs

throw new FormatException("Invalid ip-adress"); -> "Invalid ip-address"

This string is not referenced by any test, doc or FAQ entry in the repository.

Notes for reviewers

  • No identifiers were renamed. A scan also flagged the local variables ilfixAassembly, assmeblyPath, tranlater and the parameter perfix (plus its matching <param name="perfix"> doc tag). Those are all real identifiers, so I deliberately left them alone - renaming them is a separate, API-visible decision for the maintainers. (CSFix.cs:100 already carries a //TODO: tranlater的名字不太合适 note.)
  • I also deliberately left Console.WriteLine("Error: the new assembly must not be inject, ...") unchanged even though inject should grammatically be injected: that exact string is quoted verbatim as a heading in Doc/faq.md, and it is the sort of message users paste into a search engine. Changing it would desync the FAQ and break those searches. Happy to add it (and the matching FAQ line) if you would prefer.
  • Chinese-language comments were left untouched.
  • No logic changes.

- CSFix.cs: 'assmbly' -> 'assembly' (10 occurrences) in the argument
  placeholder names printed by usage(). Text output only.
- LiveDotNet.cs: FormatException message 'Invalid ip-adress' -> 'Invalid ip-address'.

No identifiers were renamed and no logic was changed.
@tencent-adm

tencent-adm commented Sep 3, 2026

Copy link
Copy Markdown
Member

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants