Add bounds check in Tags::fetchTrack to prevent heap buffer overflow#94
Open
SAY-5 wants to merge 1 commit into
Open
Add bounds check in Tags::fetchTrack to prevent heap buffer overflow#94SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a malformed file carries a
trknmetadata atom whose data value is shorter than 6 bytes,fetchTrackreadsvalue[2]throughvalue[5]past the end of the heap buffer. The other fetch helpers have the same shape, but this is the one reported in #90; mp4info crashes under AddressSanitizer on such a file. This adds avalueSize >= 6check alongside the existing NULL guard so the short value is skipped instead. Fixes #90.