Skip to content

Commit d985e3b

Browse files
deepanshu-Android (Google) Code Review
authored andcommitted
Merge changes Ib5f53f3b,I7debf3ee,Ic494ee7f,Ia8d223ae,Iff7dbbf6 into mnc-dev
* changes: Revert to using AppTheme for LayoutLib tests. Fix Matrix_Delegate.native_getValues() Update test image for upated nav icons. Fix typo: s/FullScreen/Fullscreen/ in LayoutLib. Fix bugs introduced in 78aa664.
2 parents 3ba2bfa + 89a045c commit d985e3b

6 files changed

Lines changed: 17 additions & 18 deletions

File tree

tools/layoutlib/bridge/src/android/graphics/Matrix_Delegate.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -673,7 +673,7 @@ public boolean hasPerspective() {
673673
return;
674674
}
675675

676-
System.arraycopy(d.mValues, 0, d.mValues, 0, MATRIX_SIZE);
676+
System.arraycopy(d.mValues, 0, values, 0, MATRIX_SIZE);
677677
}
678678

679679
@LayoutlibDelegate

tools/layoutlib/bridge/src/android/graphics/Path_Delegate.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import java.awt.geom.Point2D;
3737
import java.awt.geom.Rectangle2D;
3838
import java.awt.geom.RoundRectangle2D;
39-
import java.util.ArrayList;
4039

4140
/**
4241
* Delegate implementing the native methods of android.graphics.Path
@@ -504,13 +503,13 @@ public void setPathIterator(PathIterator iterator) {
504503
switch (type) {
505504
case PathIterator.SEG_MOVETO:
506505
case PathIterator.SEG_LINETO:
507-
store(coords, tmp, 1, isFirstPoint);
506+
store(tmp, coords, 1, isFirstPoint);
508507
break;
509508
case PathIterator.SEG_QUADTO:
510-
store(coords, tmp, 2, isFirstPoint);
509+
store(tmp, coords, 2, isFirstPoint);
511510
break;
512511
case PathIterator.SEG_CUBICTO:
513-
store(coords, tmp, 3, isFirstPoint);
512+
store(tmp, coords, 3, isFirstPoint);
514513
break;
515514
case PathIterator.SEG_CLOSE:
516515
// No points returned.
@@ -528,14 +527,14 @@ public void setPathIterator(PathIterator iterator) {
528527

529528
private static void store(float[] src, float[] dst, int count, boolean isFirst) {
530529
if (isFirst) {
531-
dst[0] = 0;
532-
dst[1] = src[0];
533-
dst[2] = src[1];
530+
dst[0] = 0; // fraction
531+
dst[1] = src[0]; // abscissa
532+
dst[2] = src[1]; // ordinate
534533
}
535534
if (count > 1 || !isFirst) {
536535
dst[3] = 1;
537-
dst[4] = src[2 * count];
538-
dst[5] = src[2 * count + 1];
536+
dst[4] = src[2 * count - 2];
537+
dst[5] = src[2 * count - 1];
539538
}
540539
}
541540

tools/layoutlib/bridge/src/com/android/layoutlib/bridge/impl/Layout.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ class Layout extends RelativeLayout {
8383
// Theme attributes used for configuring appearance of the system decor.
8484
private static final String ATTR_WINDOW_FLOATING = "windowIsFloating";
8585
private static final String ATTR_WINDOW_BACKGROUND = "windowBackground";
86-
private static final String ATTR_WINDOW_FULL_SCREEN = "windowFullScreen";
86+
private static final String ATTR_WINDOW_FULL_SCREEN = "windowFullscreen";
8787
private static final String ATTR_NAV_BAR_HEIGHT = "navigation_bar_height";
8888
private static final String ATTR_NAV_BAR_WIDTH = "navigation_bar_width";
8989
private static final String ATTR_STATUS_BAR_HEIGHT = "status_bar_height";
-4.49 KB
Loading
-70 Bytes
Loading

tools/layoutlib/bridge/tests/src/com/android/layoutlib/bridge/intensive/Main.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,8 @@ public void testExpand() throws ClassNotFoundException {
329329
.setNavigation(Navigation.NONAV);
330330

331331
SessionParams params = getSessionParams(parser, customConfigGenerator,
332-
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", RenderingMode.V_SCROLL,
333-
22);
332+
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", false,
333+
RenderingMode.V_SCROLL, 22);
334334

335335
renderAndVerify(params, "expand_vert_layout.png");
336336

@@ -342,8 +342,8 @@ public void testExpand() throws ClassNotFoundException {
342342
parser = new LayoutPullParser(APP_TEST_RES + "/layout/" +
343343
"expand_horz_layout.xml");
344344
params = getSessionParams(parser, customConfigGenerator,
345-
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", RenderingMode
346-
.H_SCROLL, 22);
345+
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", false,
346+
RenderingMode.H_SCROLL, 22);
347347

348348
renderAndVerify(params, "expand_horz_layout.png");
349349
}
@@ -390,7 +390,7 @@ private void renderAndVerify(String layoutFileName, String goldenFileName)
390390
// TODO: Set up action bar handler properly to test menu rendering.
391391
// Create session params.
392392
SessionParams params = getSessionParams(parser, ConfigGenerator.NEXUS_5,
393-
layoutLibCallback, "Theme.Material.Light.DarkActionBar", RenderingMode.NORMAL, 22);
393+
layoutLibCallback, "AppTheme", true, RenderingMode.NORMAL, 22);
394394
renderAndVerify(params, goldenFileName);
395395
}
396396

@@ -399,12 +399,12 @@ private void renderAndVerify(String layoutFileName, String goldenFileName)
399399
*/
400400
private SessionParams getSessionParams(LayoutPullParser layoutParser,
401401
ConfigGenerator configGenerator, LayoutLibTestCallback layoutLibCallback,
402-
String themeName, RenderingMode renderingMode, int targetSdk) {
402+
String themeName, boolean isProjectTheme, RenderingMode renderingMode, int targetSdk) {
403403
FolderConfiguration config = configGenerator.getFolderConfig();
404404
ResourceResolver resourceResolver =
405405
ResourceResolver.create(sProjectResources.getConfiguredResources(config),
406406
sFrameworkRepo.getConfiguredResources(config),
407-
themeName, false);
407+
themeName, isProjectTheme);
408408

409409
return new SessionParams(
410410
layoutParser,

0 commit comments

Comments
 (0)