Skip to content

Commit 89a045c

Browse files
committed
Revert to using AppTheme for LayoutLib tests.
Use AppTheme for all tests other than testExpand. AppTheme contains an attribute needed by testArrayCheck. Also, since the AppTheme extends Theme.Material.Light.DarkActionBar, other tests should be unaffected. Also, update the golden image for the testArrayCheck. Change-Id: Ib5f53f3b029c5aceef2b622e5ac63952d6b1972a
1 parent 9f280a9 commit 89a045c

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

  • tools/layoutlib/bridge/tests
-4.49 KB
Loading

tools/layoutlib/bridge/tests/src/com/android/layoutlib/bridge/intensive/Main.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -329,8 +329,8 @@ public void testExpand() throws ClassNotFoundException {
329329
.setNavigation(Navigation.NONAV);
330330

331331
SessionParams params = getSessionParams(parser, customConfigGenerator,
332-
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", RenderingMode.V_SCROLL,
333-
22);
332+
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", false,
333+
RenderingMode.V_SCROLL, 22);
334334

335335
renderAndVerify(params, "expand_vert_layout.png");
336336

@@ -342,8 +342,8 @@ public void testExpand() throws ClassNotFoundException {
342342
parser = new LayoutPullParser(APP_TEST_RES + "/layout/" +
343343
"expand_horz_layout.xml");
344344
params = getSessionParams(parser, customConfigGenerator,
345-
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", RenderingMode
346-
.H_SCROLL, 22);
345+
layoutLibCallback, "Theme.Material.NoActionBar.Fullscreen", false,
346+
RenderingMode.H_SCROLL, 22);
347347

348348
renderAndVerify(params, "expand_horz_layout.png");
349349
}
@@ -390,7 +390,7 @@ private void renderAndVerify(String layoutFileName, String goldenFileName)
390390
// TODO: Set up action bar handler properly to test menu rendering.
391391
// Create session params.
392392
SessionParams params = getSessionParams(parser, ConfigGenerator.NEXUS_5,
393-
layoutLibCallback, "Theme.Material.Light.DarkActionBar", RenderingMode.NORMAL, 22);
393+
layoutLibCallback, "AppTheme", true, RenderingMode.NORMAL, 22);
394394
renderAndVerify(params, goldenFileName);
395395
}
396396

@@ -399,12 +399,12 @@ private void renderAndVerify(String layoutFileName, String goldenFileName)
399399
*/
400400
private SessionParams getSessionParams(LayoutPullParser layoutParser,
401401
ConfigGenerator configGenerator, LayoutLibTestCallback layoutLibCallback,
402-
String themeName, RenderingMode renderingMode, int targetSdk) {
402+
String themeName, boolean isProjectTheme, RenderingMode renderingMode, int targetSdk) {
403403
FolderConfiguration config = configGenerator.getFolderConfig();
404404
ResourceResolver resourceResolver =
405405
ResourceResolver.create(sProjectResources.getConfiguredResources(config),
406406
sFrameworkRepo.getConfiguredResources(config),
407-
themeName, false);
407+
themeName, isProjectTheme);
408408

409409
return new SessionParams(
410410
layoutParser,

0 commit comments

Comments
 (0)