Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: 70bf7ae The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in React city renderer that encodes metrics as building heights, category intersections as districts, and health status as building effects. Records retain their identity through the existing mark, scene, renderer, focus, and selection contracts.
Reference: https://raphox.github.io/atlas/
@tanstack/react-charts/city, mirrored at@tanstack/charts/react/city, with an optional Three.js peer.sideEffects: falseand the ordinary chart entry points. Consumers import the component without a separate stylesheet.benchmarks/conformance/cases/city-mapwith the standardcase.json, self-containedexample.tsx, typed data,tanstack.ts, isolated Plot reference, and package/case regressions.The internal Atlas engine remains JavaScript behind explicit TypeScript public contracts. This draft requests feedback on the API and package placement. The Atlas code is offered under the repository's MIT license with authorization to distribute it.
Validation:
To try locally, run
pnpm dev:conformanceand open/charts/city-map/.