Conversation
|
Thanks, |
|
Sorry about the confusion. I accidentally mixed two separate changes into the same pull request. The RenamePath implementation and the ClientMaxMpxCount / multiplexing changes are actually two different features: RenamePath support for SMB1. Would you like me to split these into separate pull requests? I understand that would be the cleaner approach. However, I cannot promise that I will be able to do it in the near future, as I am about to go on vacation. Also, some of the comments were accidentally carried over from my internal project. They were only intended as personal notes and can simply be removed. I did not notice them when reviewing the Git diff before creating the pull request. Sorry for the noise, and thank you for taking the time to review the changes. |
|
Yes, please split when you have time, enjoy your vacation! |
SMB1Client: Add NT_TRANSACT_NOTIFY_CHANGE and RenamePath support