Conversation
Owner
|
Thanks, this is related to #314 |
TalAloni
reviewed
Sep 18, 2026
| NTStatus status = command.Header.Status; | ||
| // Invoke off the receive thread so a slow/blocking callback can never | ||
| // stall processing of further incoming packets on this connection. | ||
| System.Threading.ThreadPool.QueueUserWorkItem(delegate |
Owner
There was a problem hiding this comment.
One thing that comes to mind even before starting to review this:
System.Threading.ThreadPool.QueueUserWorkItem is a good default,
but there should be a "protected virtual" method for this - in case the user does not want to use the shared thread-pool.
Owner
|
Thanks, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.