Device license changes by KenVanHoeylandt · Pull Request #596 · TactilityProject/Tactility

KenVanHoeylandt · 2026-07-28T08:13:31Z

I'm changing the license of some (most) devices from GPL v3.0 to Apache License v2.0 with consent of the involved authors:

✔️ Shadowtrance: consent via Discord, will also ask explicit consent in the comments
✔️ NellowTCS: consent via Discord, will ask explicit consent in the comments
✔️ Crazypedia consented here for T-Deck Max. I built the T-Deck Pro dts based on it, so that's indirectly affected.

Summary by CodeRabbit

Licensing / Documentation
- Added the full Apache License 2.0 text for many device and test projects.
- Added the full GNU GPL v3.0 text where applicable.
- Updated the main licensing guidance to include explicit license references and clearer notes that licensing varies by project.
Behavior / Updates
- Updated an unphone navigation button action to no longer trigger the previous “stop app” behavior.
- Improved power-wake error reporting and refined related boot log messages for clearer outcomes.

coderabbitai · 2026-07-28T08:14:13Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

📝 Walkthrough

Walkthrough

Expanded LICENSE.md with license listings, project licensing guidance, GPLv3-to-Apache considerations, and variable license classifications. Added complete Apache License 2.0 documents across device and test directories, plus complete GPLv3 documents for the LilyGo THMI device and Tactility tests. Updated component dependencies and modified UnPhone navigation, wake-error handling, and boot logging behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is related to the PR, but it is too generic to convey the main change or scope.	Use a more specific title like 'Add Apache 2.0 licenses to device trees and update license documentation'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch device-license-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

Devices/btt-panda-touch/LICENSE-Apache-2.0.md (1)

7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Handle Markdownlint warnings without changing the license text.

All added Apache license copies trigger heading hierarchy/style warnings. Prefer excluding LICENSE-Apache-2.0.md files from MD001/MD003, or apply one consistent formatting transformation to every copy rather than changing only selected documents.

Devices/btt-panda-touch/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/cyd-2432s024c/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/cyd-2432s024r/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/cyd-2432s028r/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/lilygo-tdongle-s3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/lilygo-tlora-pager/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/m5stack-cardputer-adv/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/m5stack-cardputer/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/m5stack-core2/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/m5stack-cores3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Devices/m5stack-papers3/LICENSE-Apache-2.0.md#L7-L9: adjust lint configuration or consistently normalize headings.

Source: Linters/SAST tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 48eddc95-34ec-49c9-8d3e-b7a91887931f

📥 Commits

Reviewing files that changed from the base of the PR and between e6e1dcd and 7e4da2f.

📒 Files selected for processing (53)

Devices/btt-panda-touch/LICENSE-Apache-2.0.md
Devices/cyd-2432s024c/LICENSE-Apache-2.0.md
Devices/cyd-2432s024r/LICENSE-Apache-2.0.md
Devices/cyd-2432s028r/LICENSE-Apache-2.0.md
Devices/cyd-2432s028rv3/LICENSE-Apache-2.0.md
Devices/cyd-2432s032c/LICENSE-Apache-2.0.md
Devices/cyd-3248s035c/LICENSE-Apache-2.0.md
Devices/cyd-4848s040c/LICENSE-Apache-2.0.md
Devices/cyd-8048s043c/LICENSE-Apache-2.0.md
Devices/cyd-e32r28t/LICENSE-Apache-2.0.md
Devices/cyd-e32r32p/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-advance-28/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-advance-35/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-advance-50/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-basic-28/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-basic-35/LICENSE-Apache-2.0.md
Devices/elecrow-crowpanel-basic-50/LICENSE-Apache-2.0.md
Devices/generic-esp32/LICENSE-Apache-2.0.md
Devices/generic-esp32c6/LICENSE-Apache-2.0.md
Devices/generic-esp32p4/LICENSE-Apache-2.0.md
Devices/generic-esp32s3/LICENSE-Apache-2.0.md
Devices/guition-jc1060p470ciwy/LICENSE-Apache-2.0.md
Devices/guition-jc2432w328c/LICENSE-Apache-2.0.md
Devices/guition-jc8048w550c/LICENSE-Apache-2.0.md
Devices/heltec-wifi-lora-32-v3/LICENSE-Apache-2.0.md
Devices/lilygo-tdeck-max/LICENSE-GPL-3.0.md
Devices/lilygo-tdeck-plus/LICENSE-Apache-2.0.md
Devices/lilygo-tdeck-pro/LICENSE-GPL-3.0.md
Devices/lilygo-tdeck/LICENSE-Apache-2.0.md
Devices/lilygo-tdisplay-s3/LICENSE-Apache-2.0.md
Devices/lilygo-tdisplay-s3/source/module.cpp
Devices/lilygo-tdisplay/LICENSE-Apache-2.0.md
Devices/lilygo-tdongle-s3/LICENSE-Apache-2.0.md
Devices/lilygo-thmi/LICENSE-GPL-3.0.md
Devices/lilygo-tlora-pager/LICENSE-Apache-2.0.md
Devices/m5stack-cardputer-adv/LICENSE-Apache-2.0.md
Devices/m5stack-cardputer/LICENSE-Apache-2.0.md
Devices/m5stack-core2/LICENSE-Apache-2.0.md
Devices/m5stack-cores3/LICENSE-Apache-2.0.md
Devices/m5stack-papers3/LICENSE-Apache-2.0.md
Devices/m5stack-stackchan/LICENSE-Apache-2.0.md
Devices/m5stack-stickc-plus2/LICENSE-Apache-2.0.md
Devices/m5stack-sticks3/LICENSE-Apache-2.0.md
Devices/m5stack-tab5/LICENSE-Apache-2.0.md
Devices/simulator/LICENSE-Apache-2.0.md
Devices/unphone/LICENSE-Apache-2.0.md
Devices/waveshare-esp32-s3-geek/LICENSE-Apache-2.0.md
Devices/waveshare-s3-lcd-13/LICENSE-Apache-2.0.md
Devices/waveshare-s3-touch-lcd-128/LICENSE-Apache-2.0.md
Devices/waveshare-s3-touch-lcd-147/LICENSE-Apache-2.0.md
Devices/waveshare-s3-touch-lcd-43/LICENSE-Apache-2.0.md
Devices/wireless-tag-wt32-sc01-plus/LICENSE-Apache-2.0.md
LICENSE.md

💤 Files with no reviewable changes (1)

Devices/lilygo-tdisplay-s3/source/module.cpp

coderabbitai

🧹 Nitpick comments (1)

Tests/SdkIntegration/LICENSE-Apache-2.0.md (1)

7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Normalize or exempt the Markdown heading structure in the Apache license copies.

All four files skip heading levels at Lines 7 and 9 and mix ATX headings with a setext title, triggering the same markdownlint warnings.

Tests/SdkIntegration/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.

Tests/TactilityFreeRtos/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.

Tests/TactilityKernel/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.

Tests/crypt-module/LICENSE-Apache-2.0.md#L7-L9: normalize or exempt these headings.

Source: Linters/SAST tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b31357a9-ba80-4997-a5d0-5a15e4331cae

📥 Commits

Reviewing files that changed from the base of the PR and between 7e4da2f and 0dc2ccf.

📒 Files selected for processing (6)

LICENSE.md
Tests/SdkIntegration/LICENSE-Apache-2.0.md
Tests/Tactility/LICENSE-GPL-3.0.md
Tests/TactilityFreeRtos/LICENSE-Apache-2.0.md
Tests/TactilityKernel/LICENSE-Apache-2.0.md
Tests/crypt-module/LICENSE-Apache-2.0.md

🚧 Files skipped from review as they are similar to previous changes (1)

LICENSE.md

NellowTCS · 2026-07-29T05:16:37Z

I agree with the changes!

Shadowtrance · 2026-07-29T15:22:04Z

Yes i agree.

#552 (comment)

coderabbitai

🧹 Nitpick comments (1)

Devices/lilygo-tdeck-max/LICENSE-Apache-2.0.md (1)

7-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Resolve the shared Markdown lint configuration mismatch.

Both copied Apache license documents trigger MD001/MD003 because the canonical heading structure is incompatible with the repository’s Markdown rules. Either normalize both copies—and the canonical source—or exempt canonical license texts from these stylistic checks.

Devices/lilygo-tdeck-max/LICENSE-Apache-2.0.md#L7-L9: Apply the shared heading/linting fix.

Devices/lilygo-tdeck-pro/LICENSE-Apache-2.0.md#L7-L9: Apply the same shared fix.

Source: Linters/SAST tools

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dd497573-f86c-4321-b972-d6190f28a088

📥 Commits

Reviewing files that changed from the base of the PR and between 0dc2ccf and 82b1acc.

📒 Files selected for processing (2)

Devices/lilygo-tdeck-max/LICENSE-Apache-2.0.md
Devices/lilygo-tdeck-pro/LICENSE-Apache-2.0.md

To avoid including GPL code

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fc30aa91-1ef2-4209-b51a-00874a344b2f

📥 Commits

Reviewing files that changed from the base of the PR and between 82b1acc and 50e8ec9.

📒 Files selected for processing (5)

Devices/lilygo-tlora-pager/CMakeLists.txt
Devices/unphone/CMakeLists.txt
Devices/unphone/source/drivers/unphone_nav_buttons.cpp
Devices/unphone/source/drivers/unphone_power_switch.cpp
Devices/unphone/source/init_boot.cpp

Still waiting for changes on other branch to remove usage

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e45a584-13df-443a-a608-25ed421ef2d3

📥 Commits

Reviewing files that changed from the base of the PR and between 50e8ec9 and c169574.

📒 Files selected for processing (3)

Devices/lilygo-tlora-pager/CMakeLists.txt
Devices/lilygo-tlora-pager/source/module.cpp
Drivers/lilygo-module/CMakeLists.txt

💤 Files with no reviewable changes (1)

Devices/lilygo-tlora-pager/source/module.cpp

🚧 Files skipped from review as they are similar to previous changes (1)

Devices/lilygo-tlora-pager/CMakeLists.txt

Changed device licenses

7e4da2f

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread LICENSE.md Outdated

Comment thread LICENSE.md Outdated

KenVanHoeylandt added 2 commits July 28, 2026 23:12

Merge branch 'main' into device-license-updates

d0e8978

License updates

0dc2ccf

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

KenVanHoeylandt added 2 commits July 29, 2026 17:31

Merge branch 'main' into device-license-updates

eb896d2

T-Deck Pro and Max get Apache license after Crazypedia's approval

82b1acc

#552 (comment)

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

KenVanHoeylandt added 3 commits July 29, 2026 18:47

Merge branch 'main' into device-license-updates

21d6e7f

Dependency cleanup

6595734

To avoid including GPL code

Dependency cleanup

50e8ec9

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread Devices/unphone/source/drivers/unphone_nav_buttons.cpp

KenVanHoeylandt added 3 commits July 30, 2026 00:30

Dependency cleanup

73c9ee3

Remove Tactility dependency

b5e7953

Still waiting for changes on other branch to remove usage

Merge branch 'main' into device-license-updates

c169574

coderabbitai Bot reviewed Jul 30, 2026

View reviewed changes

Comment thread Drivers/lilygo-module/CMakeLists.txt

Merge branch 'main' into device-license-updates

ce93aae

KenVanHoeylandt merged commit 606b918 into main Jul 30, 2026
61 checks passed

KenVanHoeylandt deleted the device-license-updates branch July 30, 2026 15:19

Navigation Menu

Uh oh!

Uh oh!

Device license changes - #596

Device license changes#596
KenVanHoeylandt merged 12 commits into
mainfrom
device-license-updates

KenVanHoeylandt commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

Reviews paused

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

NellowTCS commented Jul 29, 2026 •

edited

Loading

Uh oh!

Shadowtrance commented Jul 29, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

KenVanHoeylandt commented Jul 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

❌ Failed checks (1 inconclusive)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

NellowTCS commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Shadowtrance commented Jul 29, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

KenVanHoeylandt commented Jul 28, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 28, 2026 •

edited

Loading

NellowTCS commented Jul 29, 2026 •

edited

Loading