Repository navigation
test: drop redundant tests, render each page once, run SSR only in the ssr group - #110
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LastModifiedreadsgit logonce per run instead of once per URL: a sitemap was 739 git processes (6.9s), now one (0.2s). Samelastmodfor all 740 URLs.requireSsr()turns it on, probes the service once per process, and makes a failed render throw instead of falling back to the client shell.->group('ssr');requireSsr()/requireSsrJob()fail a test that isn't in it. Thephpjob runs--exclude-group=ssr, thessrjob--group=ssr.seoCrawlProps(),seoCrawlHtml()inSeo/helpers.php), down from about ten crawls of 749 URLs.seoCommittedSitemap()).DeployScriptTestshares sandbox runs: 14 full runs down to 7, plus 3 that skip the git setup.php162s → 52s,ssr250s → 40s. Peak memory fits the default 512M.