Repository navigation
ci(release): fail the CloudKit check only on what Production lacks (#3800) - #3801
Merged
Merged
Conversation
datlechin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appjob runsexport-cloudkit-schema.sh --check-deployed, which fails only on what the line's snapshot has and Production lacks. v0.82.1 failed the exact--checkbecause Production hasConnection.sshRouteJson(feat(sync): carry the Mac's SSH route to iPhone and iPad #3769).scripts/release/schema.py,scripts/release/test_schema.py,scripts/export-cloudkit-schema.sh. The rule line indata-sync-storage.mdis ported by hand.Test plan
schema.py,test_schema.pyandexport-cloudkit-schema.shequal main's after ci(release): fail the CloudKit schema check only on what Production lacks #3800.test_schema.pyincluded; shellcheck and actionlint pass.schema.py coverswith this line's snapshot against main's (Production) passes.