Repository navigation
fix(sync): refuse a push built on a stale record and merge it again - #3773
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ifServerRecordUnchanged), so a push built on an older copy of a record is refused.iditem by item. Slash commands two Macs added under one name both stay, the later one asname-2. Shortcuts, AI settings and themes go up whole, since their options depend on each other.PushOutcome.mergelets a later save clear an earlier failure.Test plan
SyncRecordEditTests(package),SyncConflictRebaseTests(macOS), andIOSSyncCoordinatorTestscases for a dirty connection, a saved query and an undo during a merged save, one per case above.SyncedWriteFailureTests.unsavedSavedQueryHoldsOnlyTheTokennow expects an unsaved saved query to stay out of the cache.verify.sh: package TableProCore (3668), macOS sync suites (292), iOS sync suites (139), lint.Needs the maintainer
Follows #3769.