Repository navigation
ci: replace the changelog checker with towncrier and two small checks - #3587
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
scripts/ci/check-changelog.py, its tests, and its steps in Repo Hygiene and PR title.towncrier build --draftforappleandlinux. It refuses an unknown type or a non-numeric PR number.apple/CHANGELOG.mdorlinux/CHANGELOG.mdunless the title starts withchore(release). It reads the merge commit's diff to its first parent, the PR's own change.version.py checkrefuses a lead on a patch, a lead over 6 lines, and a lead line starting with#or-._new_section_problemsis kept. Its only other check,notes.py cannot find ## [X], cannot fire once the heading matched..claude/rules/changelog.mdis 5 facts.ci.md,apple/RELEASING.mdandlinux/docs/releasing.mdno longer say the checker runs.Verified
test_version.pyfail with the rules removed.verify.sh agent-docspass locally.Not in this PR
AGENTS.mdstill lists a changelog check inscripts/ci; the AGENTS.md PR owns that line.