Repository navigation
feat(linux): translate the SSH field checks and connection write errors - #3586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release criterion 9: no message the user cannot have translated. The SSH host, username and jump host checks showed the ssh crate's English detail, and a failed write of the saved connections showed the storage error's English text.
Change
SshFailure::InvalidDestinationcarries anSshDestinationProblem(part, character, port text). The app words each one.Verified
New tests pin each mapping in core, ssh, session and app. Changed on purpose:
each_failure_says_what_happened,only_a_problem_with_the_chosen_file_blames_it,a_bad_row_names_the_row_it_is_in,destination_rejects_empty_leading_dash_whitespace_control_and_port_zero(noweach_refusal_names_the_part_and_what_is_wrong_with_it).Not in this PR
ssh -G, an ssh that would not start and a master that exited silently; a TLS failure the app does not classify. Listed in ROADMAP.md, criterion 9.