Repository navigation
test(linux): run the million-row case on SQLite in its own binary - #3583
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release criterion 4 still needed the 1,000,000-row page-and-export test on SQLite. Its suites run in the unit suite under
cargo test, where one binary's tests share a process, so a resident peak measured there would count theirs too.Change
crates/drivers/sqlite/tests/large_table.rsis a test target holding only this case, so its process is its own. The fast job's unit suite runs it.large_table_conformance_suite!takesdocker: true | false. The five server drivers passtrue.tests/integration/sqlite_engine.rs, which both targets include. It fills the table with a recursive CTE.Verified
stream_readbuffering every row, the case fails at +313.7 MiB.