Repository navigation
fix(settings): draw editable values in the theme and remove leftover theme paths - #3582
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Under a custom theme, editable row inspector values drew a light system box beside themed read-only and multi-line values. A rounded bezel paints its own fill and edits in the window's shared field editor, so no theme color reaches it. A few other surfaces still bypassed the theme carriers.
Change
ValueTextField: a borderless field filling the value well, with the system focus ring and its own field editor on the theme's caret and selection. Text replacement no longer rewrites typed values.Verified
InspectorValueThemeTests.editableValueTakesTheEditorBackgroundfails on main and passes here. Changed on purpose:dumpDefaultHasNoWellandStatusBarChromeTests. Removed:canvasBackdropFollowsTheTheme,otherBarsKeepTheirMaterial.Screenshots
Tokyo Night, row inspector, before and after:
Whole window, after:
Not in this PR
Tables in Users & Roles and Compare stay chrome (theme.md).SchemaTextFieldViewstays a bezel with text replacement on.