Repository navigation
test(linux): wait for the parked banner text, format the session module - #3536
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
linuxfails Fast checks on rustfmt since #3530 shortened the#[expect]reason insession/mod.rs, which now fits on one line. Flatpak x86_64 also faileda_parked_session_says_what_the_server_said: the banner still read "Connection lost. Reconnecting (attempt 1)." The banner follows the session's health after it changes and offers Retry while reconnecting too, so waiting for the Retry button could return before the failed text arrived.Change
cargo fmtonsession/mod.rs.Verified
fmt check passes; the 15
health_bannertests pass 5 runs in a row in the Linux dev image.