Skip to content

fix(release): walk the CI check back to the last change it covers - #3531

Merged
datlechin merged 1 commit into
mainfrom
fix/release-walk-to-last-suite-change
Oct 18, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/release-walk-to-last-suite-change

Conversation

@datlechin

Copy link
Copy Markdown
Member

Why

version.py check looks for a green macOS Tests, iOS and Package Tests and Release Build run in only the last 50 first-parent commits of a tag. Once the Linux app lands on main, its commits skip those suites, so 50 Linux-only commits in a row would refuse a macOS release that nothing invalidated.

Change

  • The walk has no fixed depth. It ends at the first green run, or at the newest commit that changed the files the suite reads, since no run before that commit covers it.
  • That second case now names the commit: "no macOS Tests run that was not skipped on , which changed files it reads, or after it".
  • RELEASING.md, Workflows, says the borrowed run must come after the last change to those files.

Verified

test_version.py: the two new cases fail on main and pass here; all 33 pass.

@datlechin
datlechin merged commit e46b8b8 into main Oct 18, 2026
7 checks passed
@datlechin
datlechin deleted the fix/release-walk-to-last-suite-change branch October 18, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant