Repository navigation
fix(release): walk the CI check back to the last change it covers - #3531
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
version.py checklooks for a green macOS Tests, iOS and Package Tests and Release Build run in only the last 50 first-parent commits of a tag. Once the Linux app lands on main, its commits skip those suites, so 50 Linux-only commits in a row would refuse a macOS release that nothing invalidated.Change
RELEASING.md, Workflows, says the borrowed run must come after the last change to those files.Verified
test_version.py: the two new cases fail on main and pass here; all 33 pass.