Repository navigation
ci(changelog): suggest <type>.md when an added file has no type - #3521
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
changelog.dfile in the PR title hint. Forchangelog.d/notes.txtit printed "Name it changelog.d/3600.txt", which towncrier's strict draft in Repo Hygiene then refuses as an invalid fragment name. Before ci(changelog): let towncrier own fragment names and the release section #3514 the hint was3600.<type>.md.Change
fixed.md,fixed.2.md). Otherwise it printschangelog.d/<number>.<type>.md.Verified
test_a_file_that_is_not_a_fragment_gets_the_type_placeholderfails on main fornotes.txtandREADME.mdand passes here. It replacestest_a_file_that_is_not_a_fragment_is_refused, which checked only that the file is refused.