Repository navigation
ci(release): use stock tools for the feed, release and plugin manifest - #3518
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release tooling re-implemented what
gh, git, Actions and the Python stdlib already do. Audit items: feed-2 to feed-12, feed-missed-1, feed-missed-2, notes-1, notes-missed-1, pipeline-1, pipeline-4, pipeline-5 (release.yml), pipeline-12, pipeline-13, docs-1, docs-5, docs-6 and docs-12 (feed.py, RELEASING.md Keys and environments, ci.md), docs-14, build-9, plugins-1, plugins-2, plugins-4, plugins-5, plugins-missed-1 (Python, JSON and check parts).Change
github-release:actions/attest, thengh release create(draft, upload, publish), thengh release verifyandverify-asset.publish.pygoes;feed.py latestserves withdraw.yml.feedandwithdraw:feed.pyedits agh-pagescheckout and the job commits and pushes. Concurrencygh-pageswithqueue: maxreplaces the retry loop; actionlint 1.7.12 ignores that key until Actionlint does not know aboutqueue:key for concurrency rhysd/actionlint#657 lands. Assets are checked withgh release verify-asset,generate_appcastsigns, withdraw edits withxml.dom.minidom, and both refuse an appcast whose signature does not verify.exportFormatIds, dropsiconName.registry.pyloses its dead CLI and re-checks;check-plugin-manifest.pyreadsproject.ymlwith PyYAML.version.py checkrefuses a stable tag that still holds fragments.Verified
scripts/releaseandscripts/citests, actionlint 1.7.12, shellcheck.test_feed.py,test_registry.pyandtest_check_plugin_manifest.pyare rewritten for the new shapes;test_publish.pygoes withpublish.py.Not in this PR
RELEASING.mdconflicts with build(release): build, sign and package with stock Apple tools #3512 on the adjacentverifyandappbullets. Whichever merges second mergesmainin and keeps both: the fragment clause onverifyfrom this PR, theappwording from build(release): build, sign and package with stock Apple tools #3512.