Repository navigation
build(native): read bridge toolchains from their pin files - #3513
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
build-hana.shforcedgo1.27.1over thetoolchain go1.27.2pin ingo.mod, so plugin-hana 1.0.1 to 1.0.3 shipped a helper without the GO-2026-6607 fix.build-dameng.shandCONTRIBUTING.mdkept their own copies of the Rust and Go versions. Release rewrite plan, cleanup after step 23; audit item docs-7.Change
build-hana.shsetsGOTOOLCHAINfrom thetoolchainline ofgo.modand signs the helper with-o runtime -s -.build-dameng.shrunsrustup toolchain install --no-self-updateandcargoin the bridge folder, sorust-toolchain.tomlpicks the release and targets and rustup itself is left alone.bothlipos straight from cargo's output intolibdameng_bridge.a.universalalias is gone from both scripts.verify_deployment_targetindeployment-target.sh, moved frommacos.sh. It reads every slice (otool -arch all) and fails a file that records no minimum.CONTRIBUTING.md, the Dameng README and the HANA notices point at the pin files.Verified
build-hana.sh bothandbuild-dameng.sh both:liposhows x86_64 and arm64, minos 13.0, the helper is go1.27.2 withadhoc,runtimeand runs on both architectures.rustup toolchain install --no-self-updateexits 0 with the update server unreachable; without the flag it exits 1.Libs/and fails a fat file whose x86_64 slice targets 15.0.AllPluginsbuilds on those outputs andverify-plugin-loads.shloads all 41,HanaDriverandDamengDriverincluded.