Repository navigation
fix(ci): fail check-plugin-provides --write on an unreadable plugin - #3505
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/ci/check-plugin-provides.py --writeprintedstamped OddDriverPlugin: declares neither databaseTypeId nor formatId as a string literaland exited 0 for a plugin it could not read, leaving its Info.plist unchanged. The unreadable case went into the same list as the key mismatches, and--writeprinted that whole list as stamped. Follows #3502.Change
problems_inraisesUnreadableinstead of returning it as a mismatch.--writeprintsstamped <Plugin>/Info.plistonly for plists it rewrote, prints each unreadable plugin as an::error::and exits 1.--writeonly when a mismatch is left for it to fix.Verified
test_write_fails_on_an_unreadable_plugin_and_leaves_its_plistfails on main and passes here; the fullscripts/cisuite passes on Python 3.9.test_check_plugin_provides.pynow expectUnreadableto be raised.