Repository navigation
fix(settings): stop the Themes list jumping when accessibility reads it - #3504
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
testThemesListScrollsAndTakesArrowKeysfailed on main and on PRs: the CI recordings show the list reaching the bottom, then snapping back. The list's table sizes a row it has not measured at 24 pt; a theme row is 42 pt. An accessibility read (XCUITest, VoiceOver) drops off-screen rows back to that estimate and remeasures them, so the rows above the visible ones change height and the list jumps.Change
Verified
AppearancePaneListTestsreads the list through the AX API while scrolling. It fails on main ("Rows {14, 5} moved to {9, 6} while nothing scrolled") and passes here.Not in this PR