Repository navigation
chore(libs): drop build-freetds.sh's stale publish comment - #3489
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/build-freetds.shstill carried a publish command from before #3481. It names only the fourlibsybdbarchives, but one run also rebuildsLibs/ios/FreeTDS.xcframework, sopublish-libs.shrefuses that command with "FreeTDS.xcframework (differs from HEAD)". The script's own NEXT STEPS output names the right set, so the file gave two different commands. The tarball cache comment also kept the rest of the old/tmpbuild root note that #3481 trimmed elsewhere.Change
Verified
Comment-only change.
bash -nand shellcheck report nothing new.Not in this PR
RELEASING.md:61still names the deletedscripts/publish-ios-libs.sh, soscripts/check-doc-symbols.shfails on main. RELEASING.md and CONTRIBUTING.md belong to the release runbook rewrite.