Skip to content

refactor(plugins): one install prompt for drivers and export formats - #3479

Merged
datlechin merged 1 commit into
mainfrom
refactor/one-plugin-install-prompt
Oct 17, 2026
Merged

datlechin merged 1 commit into
mainfrom
refactor/one-plugin-install-prompt

Conversation

@datlechin

@datlechin datlechin commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Why

Four copies of the same confirm, download and error flow: two SwiftUI modifiers (connection and type) and two AppKit prompts (driver for a file, export format). Two alert messages also pointed at a plugin marketplace the app no longer has.

Change

  • PluginInstallPrompt replaces MissingDriverPluginPrompt and MissingExportFormatPrompt: one confirm, run and error path, on PluginInstallProgressPresenter.run.
  • One generic pluginInstallPrompt(for:type:onInstalled:) modifier replaces the connection and type modifiers. A failed install now reports through AlertHelper, like the other two prompts.
  • The presenter's begin, update and end are private; history comments and file headers go.
  • "plugin marketplace" is gone from the not-installed messages; catalog synced from Xcode's stringsdata.

Verified

Build passes; no new test, the change is alert and panel presentation with no new logic.

@datlechin
datlechin merged commit 449a717 into main Oct 17, 2026
7 checks passed
@datlechin
datlechin deleted the refactor/one-plugin-install-prompt branch October 17, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant