Repository navigation
fix(welcome): match connection rows by the types a plugin provides - #3478
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A saved connection whose driver plugin failed to load or is outdated never showed the warning triangle in the Welcome window. The row compared the connection's plugin type id (
Cassandra) to the rejected plugin's bundle and registry ids (com.TablePro.CassandraDriver), which never match.Change
providedDatabaseTypeIds, the same matchdriverUnavailability(for:)uses.WelcomeViewModel+Rows.swift.Verified
WelcomeViewModelTests/testARejectedPluginFlagsEveryConnectionOfTheTypesItProvidesfails on main and passes here.Not in this PR
pluginsRejected, so a row drawn before a late rejection shows the triangle only on the next reload.