Repository navigation
feat(settings): rebuild the theme system and theme every content surface - #3452
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A theme reached only part of the window. Many content views drew system colors, pane bars drew a system band over a themed window, and a slot a theme left out could clash with its background. Edits reached open windows only through Settings, and four themes shipped.
Change
TableProThemepackage: the slot registry with fallback rules, the file format, the resolver and VS Code theme import. The engine follows the catalog and previews unsaved edits live.Verified
Unit plan, TableProCore package tests and the related UI flows pass. Changed on purpose:
AppearanceSettingsUITests,EditorThemeBridgeTests,ThemeContrastTests(light themes held to WCAG 3:1),EditorTabStripTrackThemeTests,HighlightedSQLTextViewLayoutTests,DetailSurfaceThemeTests,ThemeFileImporterTests.Screenshots
Before and after, Dracula:
New light theme (Solarized Light):
Appearance pane, before and after:
Theme Editor:
Not in this PR
DDLTextViewandTriggerEditorViewignore the editor font.