Repository navigation
fix(linux-ssh): offer no key replace under StrictHostKeyChecking yes - #3451
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a tunnel's host key changed, the review offered Replace. Under
StrictHostKeyChecking yes, Replace removed the old key and the retry then stopped on an unknown key the app may not trust, so the user lost the key for nothing. The connect error for an unknown key under strict config also read "(key )" and told the user to review the key in the app, which the config does not allow.Change
HostKeyChangedcarriestrust_allowed, from thessh -Glookup the connect already runs for the destination and each jump host. It is false when that host's own config saysyes.ask,accept-new,no, unset and a failed lookup behave as before.Verified
yesis reported as not trustable and ssh then refuses without asking; a jump host's own config decides;ask,accept-newandnostill allow trusting.ssh -Gfor all five values. The banner test offers no Replace. The error text test failed before with "(key )".