Repository navigation
fix(linux-clickhouse): read the process list before the query log - #3449
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A ClickHouse write that ran past its deadline could resolve as Unresolvable even though it applied. That is the Docker test flake from #3437. The resolver read
system.query_log, thensystem.processes. An ALTER that finished between the two reads was in neither.Change
system.processesfirst, then flush and read the log. The server queues a statement's last log entry before it takes the statement off the list, so a statement that ends between the reads is either still listed or has its end in the flushed log.system.processesresolves from the log alone instead of failing with ACCESS_DENIED. ClickHouse 25.8's stock config setsselect_from_system_db_requires_grant.Verified
an_alter_that_ends_between_the_list_and_the_log_is_appliedholds the ALTER withSYSTEM STOP MERGESand lets it finish between the two reads. The old order answered Unresolvable there.resolve_refused_the_process_list_answers_from_the_logfailed on the old code with error 497.Not in this PR
commit_with_no_record_is_unresolvableandcalls_share_one_call_optionseach failed once while a build ran beside the suite, and passed in every later run.