Repository navigation
fix(plugins): ask ClickHouse which settings and catalog it has - #3445
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On ClickHouse 23.8.0 to 23.8.8 every query after connect failed with
UNKNOWN_SETTING: the driver senthttp_write_exception_in_output_formatfrommajor.minor >= 23.8, and the setting reached the 23.8 line in 23.8.9. Other gates in that version table were wrong too.Change
system.settingsand a one-row catalog check. It sends a URL setting only when this user may change it, and reads a catalog column only when it exists. This fixes ClickHouse driver: every query fails on a 23.8.x server older than 23.8.9 — UNKNOWN_SETTING (code 115) for http_write_exception_in_output_format #3444 and letsreadonly = 1users connect.FORMATclause shows one Output value in the grid and stops an export with a message.SHOW CREATE FUNCTIONis gone.CREATE OR ALTERon 2016 SP1 and Azure SQL.Verified
ClickHouseConnectProfileTestsandClickHouseStreamFailureTestsdrive the driver through a stub. A harness on these sources passed on live 23.8.8.20, 25.8.33.6 and 26.3.52.9;mainfails there with code 115.ClickHouseServerProfileTestsreplacesClickHouseCapabilitiesTests, which pinned the 23.8 gate.Not in this PR
system.partsis denied to users without system grants on 25.8's shipped config, so table sizes fail for them.\rwhen a profile setsoutput_format_tsv_crlf_end_of_line.Fixes #3444